fix: ensure that currentRow can not go out of the range#5386
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Aug 20, 2025
Merged
fix: ensure that currentRow can not go out of the range#5386Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
|
This manifests as an OOM in our usage of xterm.js 
|
Tyriar
approved these changes
Aug 20, 2025
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
This looks good, thanks for the investigation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the code today, it is possible to get into a situation where the currentRow goes out of the range and will continue going in one direction until an out-of-memory crash.
There is no easy repro - the only one that works for me is to open an xterm inside Cursor, open the nano editor in a terminal, enter 10 one-character lines (like a, b, c, d, ...), and then make the option + click as quickly as possible.