Skip to content

Revert conpty-specific reflow handling#5358

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:tyriar/reflow_bounds
Jun 18, 2025
Merged

Revert conpty-specific reflow handling#5358
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:tyriar/reflow_bounds

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Jun 18, 2025

This reverts commit a260f7d, reversing changes made to 2042bb8 (#5321).

Fixes #5357
Reopens #5319, #3513, #4231

This caused some pretty major issues where the buffer could essentially get bricked (microsoft/vscode#251800 (comment)). The situation was much better before.

This reverts commit a260f7d, reversing
changes made to 2042bb8.
@Tyriar Tyriar added this to the 6.0.0 milestone Jun 18, 2025
@Tyriar Tyriar self-assigned this Jun 18, 2025
@Tyriar Tyriar enabled auto-merge June 18, 2025 13:11
@Tyriar Tyriar changed the title Revert "Merge pull request #5321 from Tyriar/5319" Revert conpty-specific reflow handling Jun 18, 2025
@Tyriar Tyriar merged commit 8a16a55 into xtermjs:master Jun 18, 2025
12 checks passed
@ulrrmehdi
Copy link
Copy Markdown

Is this what you suggested to revert? I had this box checked in, as suggested by Megan. Also to remind the problem solution: I am NOT working in VS Code on MS Windows.

@ulrrmehdi
Copy link
Copy Markdown

Screenshot 2025-07-03 at 8 17 48 AM

@ulrrmehdi
Copy link
Copy Markdown

ulrrmehdi commented Jul 3, 2025

Resizing Terminal window does not do anything to me after the Terminal is cleared after the 15 min idle time. The content in the Terminal does not come back :(. This problem is VERY annoying. First of all, I have no idea how that happened in the first place, after NOT having it before. It is weird.

@ulrrmehdi
Copy link
Copy Markdown

The only way to bring the content back is to open a new Terminal, type my work related settings, like navigating to the right workspace, setting aliases, all my normal work flow ... until this nasty thing happens if I do not do anything in this terminal for 15 min. Also, why 15 min, what this magic number is? Have you thought about it? Perhaps, I can set this time out be an hour, for instance, or anything much longer than 15 min?

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 5, 2025

@ulrrmehdi I don't know what you're talking about, is there some context in an issue you created somewhere I'm missing? The code this changes only affects you if you're on Windows, regardless of whether that setting is checked.

@ulrrmehdi
Copy link
Copy Markdown

The issue I am talking about, and it is not the first time I address this issue via my tickets, is a blanking out of the integrated terminal in my instance of VS Code after 15 min of it's idle time. Is it not possible to check my previous tickets and see what is there? The bottom line, the suggested resizing of the terminal does not fix anything - the content of the terminal does not come back, remains blank, until I press Output tab in the Terminal, or I open up a new Terminal, and my DEFAULT prompt reappears again, NOT the content of the Terminal before it's content had disappear without a trace! I cannot possibly type or do something in the Terminal all the time to make sure that after 15 min of not touching the Terminal screen, it does not disappear! Please find out the reason of this odd effect and suggest a working solution. Like I mentioned earlier, this effect appeared somewhat a ~month ago, and never before several years(!).

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 7, 2025

@ulrrmehdi sorry if you were directed to this PR, but this has nothing to do with that. You should create or comment on a related issue in the microsoft/vscode repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal can go blank in webgl extension

2 participants