Add comprehensive tests for alt+shift+letter keyboard combinations#5349
Merged
Add comprehensive tests for alt+shift+letter keyboard combinations#5349
Conversation
Co-authored-by: Tyriar <[email protected]>
Copilot
AI
changed the title
[WIP] Can not handle uppercase keys, such as alt+shift+h
Add comprehensive tests for alt+shift+letter keyboard combinations
Jun 5, 2025
Member
|
@copilot fix up CI: |
Co-authored-by: Tyriar <[email protected]>
Contributor
Author
... Fixed ESLint trailing spaces warning by removing trailing spaces from line 345 in Keyboard.test.ts. Commit 076f051. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Tyriar
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive test coverage for alt+shift+letter keyboard combinations that were missing from the test suite.
Background
Issue #3382 reported that
alt+shift+hwas producing^[h(lowercase) instead of the expected^[H(uppercase) behavior. However, upon investigation, the current codebase already handles this correctly:alt+shift+hcorrectly produces\x1bH(uppercase)alt+hcorrectly produces\x1bh(lowercase)The original issue reporter confirmed in a recent comment (June 2025) that the behavior is working correctly in current VS Code versions, suggesting the fix was implemented sometime between 2021 (when reported) and now.
Changes Made
Added comprehensive test cases covering:
\x1bA,\x1bH,\x1bZ)\x1ba,\x1bh,\x1bz)Testing
The new tests verify that the keyboard handling logic in
Keyboard.ts(lines 331-337) correctly:All tests pass, confirming the issue has been resolved and proper behavior is maintained.
Fixes #3382.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.