Fix selection rendering on ligatures in both renderers#5276
Merged
Tyriar merged 4 commits intoxtermjs:masterfrom Jan 6, 2025
Merged
Fix selection rendering on ligatures in both renderers#5276Tyriar merged 4 commits intoxtermjs:masterfrom
Tyriar merged 4 commits intoxtermjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5231
The solution I came up with was to simply disable ligatures when the selection state is not consistent. This works quite well and I'll likely do the same thing for cursor navigation (#5230):
Another case handled: