Skip to content

Blend cursor with background to support alpha in webgl#5260

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:5241
Dec 20, 2024
Merged

Blend cursor with background to support alpha in webgl#5260
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:5241

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Dec 20, 2024

Fixes #5241

@Tyriar Tyriar added this to the 6.0.0 milestone Dec 20, 2024
@Tyriar Tyriar self-assigned this Dec 20, 2024
@Tyriar Tyriar merged commit 5018a07 into xtermjs:master Dec 20, 2024
@Tyriar Tyriar deleted the 5241 branch December 20, 2024 15:46
@AnouarTouati
Copy link
Copy Markdown
Contributor

I think you forgot to blend the cursor accent.

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Dec 20, 2024

Just checked and you're right that did still differ between dom and webgl 👍 making another change now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme cursor alpha is being ignored for GPU renderer

2 participants