Merged
Conversation
Tyriar
approved these changes
Dec 12, 2024
Member
|
Looks great, just need to test it 👍 |
Contributor
Author
|
@Tyriar thanks! Any idea when this will be published in a new beta release? |
Contributor
Author
|
Actually it looks like it tried to publish, but the publish job failed: https://github.com/xtermjs/xterm.js/actions/runs/12298607666/job/34322412357 Related: #5252 but this doesn't fix the root cause of the 404 error...not sure what that error means. Maybe flakiness on the NPM side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5213
cc @Tyriar @jerch – per our discussions on #5213 this is adding an option to enable wrapping of the line with the cursor. This is my first time trying to modify xterm so please let me know if you have any suggestions for improvements.
I also updated the demo app with a checkbox to disable the real terminal, so it was easier for me to enable the fake one for testing (because a real shell will automatically wrap its prompt line as discussed in #5213 (comment)).
It looks like this results in the cursor being in a different place than where it started. If you have any ideas for how to resolve this, let me know. Or maybe this behavior is expected?
Untitled.mov