Fix links sometimes not activating#5171
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Sep 27, 2024
Merged
Conversation
This was a very long standing bug that was hard to nail down a repro case. Turns out this was because at some point the current link can get cleared and re-evaluated, I think because of a different fix we made. That caused the object check to fail. So the fix there is to check link equality, not js object equality. Additionally I found we don't dispose of old linkifiers when open is called multiple times. See microsoft/vscode#230010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a very long standing bug that was hard to nail down a repro case. Turns out this was because at some point the current link can get cleared and re-evaluated, I think because of a different fix we made. That caused the object check to fail. So the fix there is to check link equality, not js object equality.
Additionally I found we don't dispose of old linkifiers when open is called multiple times.
See microsoft/vscode#230010