Skip to content

Fix 'npm run package' in addon-unicode-graphemes#5151

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
PerBothner:unicode-graphemes-webpack-fix
Sep 20, 2024
Merged

Fix 'npm run package' in addon-unicode-graphemes#5151
Tyriar merged 1 commit intoxtermjs:masterfrom
PerBothner:unicode-graphemes-webpack-fix

Conversation

@PerBothner
Copy link
Copy Markdown
Contributor

If you cd addons/addon-unicode-graphemes and then do:

npm run package

you get:

ERROR in ../../out/common/services/UnicodeService.js 5:16-47
Module not found: Error: Can't resolve 'vs/base/common/event' in '/home/bothner/Software/xterm.js/out/common/services'

This fixes it.

@Tyriar Tyriar merged commit 4e9233d into xtermjs:master Sep 20, 2024
@Tyriar Tyriar added this to the 6.0.0 milestone Sep 20, 2024
@PerBothner PerBothner deleted the unicode-graphemes-webpack-fix branch September 20, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants