Skip to content

Move to vs/base disposables#5106

Merged
Tyriar merged 7 commits intoxtermjs:masterfrom
Tyriar:tyriar/lifecycle
Jul 15, 2024
Merged

Move to vs/base disposables#5106
Tyriar merged 7 commits intoxtermjs:masterfrom
Tyriar:tyriar/lifecycle

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Jul 14, 2024

This is mainly just a clean up.

  • disposeArray() -> dispose()
  • getDisposeArrayDisposable() -> combinedDisposable()
  • Disposable.isDisposed -> Disposable._store.isDisposed

@Tyriar Tyriar added this to the 6.0.0 milestone Jul 14, 2024
@Tyriar Tyriar self-assigned this Jul 14, 2024
@Tyriar Tyriar marked this pull request as ready for review July 15, 2024 17:11
@Tyriar Tyriar merged commit cb3bd46 into xtermjs:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant