Remove EventEmitter in favor of vs/base/common/event's Emitter by Tyriar · Pull Request #5104 · xtermjs/xterm.js

Tyriar · 2024-07-14T15:27:00Z

Reduces amount of code in src/common by a small amount.
Moves to more robust vscode version of event emitters, in particular this improves performance when events have a lot of listeners like our decoration related code.
Removes IEvent<T, U> which allowed firing events with 2 params instead of needing to wrap it in an object. I think the performance improvement above outweighs this loss.
The old EventEmitter is kept in the playwright test code for convenience.
~~I'll probably upstream forwardEvent to Event.forwardEvent so we can remove the Events.ts file.~~ Add Event.forward helper microsoft/vscode#221666

Tyriar · 2024-07-14T16:01:00Z

Current benchmark numbers:

Details

yarn run v1.22.21 $ NODE_PATH=./out xterm-benchmark -r 5 -c test/benchmark/benchmark.json --eval out-test/benchmark/*benchmark.js Context "out-test/benchmark/EscapeSequenceParser.benchmark.js" Context "Parser throughput - 50MB data" Context "PRINT - a" Case "#1" : 5 runs - average throughput: 822.84 MB/s Context "EXECUTE - \n" Case "#1" : 5 runs - average throughput: 192.63 MB/s Context "ESCAPE - ESC E" Case "#1" : 5 runs - average throughput: 74.69 MB/s Context "ESCAPE with collect - ESC % G" Case "#1" : 5 runs - average throughput: 95.05 MB/s Context "CSI - CSI A" Case "#1" : 5 runs - average throughput: 137.60 MB/s Context "CSI with collect - CSI ? p" Case "#1" : 5 runs - average throughput: 151.23 MB/s Context "CSI with params (short) - CSI 1;2 m" Case "#1" : 5 runs - average throughput: 167.36 MB/s Context "CSI with params (long) - CSI 1;2;3;4;5;6;7;8;9;0 m" Case "#1" : 5 runs - average throughput: 219.12 MB/s Context "OSC string interface (short seq) - OSC 0;hi ST" Case "#1" : 5 runs - average throughput: 103.54 MB/s Context "OSC string interface (long seq) - OSC 0; ST" Case "#1" : 5 runs - average throughput: 131.39 MB/s Context "OSC class interface (short seq) - OSC 0;hi ST" Case "#1" : 5 runs - average throughput: 132.90 MB/s Context "OSC class interface (long seq) - OSC 0; ST" Case "#1" : 5 runs - average throughput: 402.70 MB/s Context "DCS string interface (short seq)" Case "#1" : 5 runs - average throughput: 76.85 MB/s Context "DCS string interface (long seq)" Case "#1" : 5 runs - average throughput: 121.77 MB/s Context "DCS class interface (short seq)" Case "#1" : 5 runs - average throughput: 108.04 MB/s Context "DCS class interface (long seq)" Case "#1" : 5 runs - average throughput: 379.34 MB/s Context "out-test/benchmark/Terminal.benchmark.js" Context "Terminal: ls -lR /usr/lib" Context "write/string/async" Case "#1" : 5 runs - average throughput: 9.14 MB/s Context "write/Utf8/async" Case "#1" : 5 runs - average throughput: 12.15 MB/s "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|PRINT - a|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 6.66 skipped 6.89 SKIP median 5.10 skipped 5.48 SKIP dev 3.34 skipped 3.23 SKIP cv 0.50 skipped 0.47 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 871.35 0.90-5.00 822.84 -5.57 OK median 934.79 skipped 869.53 SKIP dev 392.95 skipped 352.38 SKIP cv 0.45 skipped 0.43 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|EXECUTE - \n|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 25.30 skipped 25.05 SKIP median 23.67 skipped 23.68 SKIP dev 3.18 skipped 3.13 SKIP cv 0.13 skipped 0.12 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 190.67 0.90-5.00 192.63 1.03 OK median 201.48 skipped 201.37 SKIP dev 22.20 skipped 22.92 SKIP cv 0.12 skipped 0.12 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|ESCAPE - ESC E|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 64.56 skipped 63.88 SKIP median 65.35 skipped 63.86 SKIP dev 1.28 skipped 1.52 SKIP cv 0.02 skipped 0.02 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 73.88 0.90-5.00 74.69 1.09 OK median 72.97 skipped 74.67 SKIP dev 1.48 skipped 1.81 SKIP cv 0.02 skipped 0.02 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|ESCAPE with collect - ESC % G|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 54.92 skipped 50.22 SKIP median 54.68 skipped 50.26 SKIP dev 0.86 skipped 1.78 SKIP cv 0.02 skipped 0.04 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 86.83 0.90-5.00 95.05 9.46 OK median 87.21 skipped 94.88 SKIP dev 1.35 skipped 3.36 SKIP cv 0.02 skipped 0.04 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI - CSI A|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.31 skipped 34.81 SKIP median 35.83 skipped 34.59 SKIP dev 1.90 skipped 2.72 SKIP cv 0.05 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 135.37 0.90-5.00 137.60 1.64 OK median 133.08 skipped 137.84 SKIP dev 7.39 skipped 10.07 SKIP cv 0.05 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with collect - CSI ? p|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 31.50 skipped 31.64 SKIP median 31.00 skipped 31.46 SKIP dev 1.70 skipped 2.15 SKIP cv 0.05 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 151.72 0.90-5.00 151.23 -0.33 OK median 153.84 skipped 151.59 SKIP dev 8.06 skipped 9.74 SKIP cv 0.05 skipped 0.06 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with params (short) - CSI 1;2 m|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 28.52 skipped 28.71 SKIP median 28.07 skipped 28.47 SKIP dev 3.39 skipped 2.88 SKIP cv 0.12 skipped 0.10 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 168.93 0.90-5.00 167.36 -0.93 OK median 169.88 skipped 167.47 SKIP dev 18.02 skipped 15.89 SKIP cv 0.11 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with params (long) - CSI 1;2;3;4;5;6;7;8;9;0 m|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 19.84 skipped 22.08 SKIP median 19.93 skipped 21.55 SKIP dev 2.45 skipped 3.16 SKIP cv 0.12 skipped 0.14 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 243.09 0.90-5.00 219.12 -9.86 OK median 239.22 skipped 221.26 SKIP dev 27.94 skipped 27.64 SKIP cv 0.11 skipped 0.13 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC string interface (short seq) - OSC 0;hi ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 45.32 skipped 46.29 SKIP median 43.34 skipped 44.42 SKIP dev 3.28 skipped 3.80 SKIP cv 0.07 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 105.63 0.90-5.00 103.54 -1.97 OK median 110.03 skipped 107.36 SKIP dev 7.23 skipped 7.97 SKIP cv 0.07 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC string interface (long seq) - OSC 0; ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.52 skipped 36.56 SKIP median 33.44 skipped 34.75 SKIP dev 3.34 skipped 3.62 SKIP cv 0.09 skipped 0.10 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 135.14 0.90-5.00 131.39 -2.78 OK median 142.61 skipped 137.21 SKIP dev 12.05 skipped 12.27 SKIP cv 0.09 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC class interface (short seq) - OSC 0;hi ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.18 skipped 36.11 SKIP median 34.46 skipped 35.39 SKIP dev 3.09 skipped 3.35 SKIP cv 0.09 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 136.33 0.90-5.00 132.90 -2.52 OK median 138.36 skipped 134.76 SKIP dev 11.31 skipped 11.64 SKIP cv 0.08 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC class interface (long seq) - OSC 0; ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 10.59 skipped 12.92 SKIP median 8.96 skipped 12.50 SKIP dev 2.69 skipped 4.35 SKIP cv 0.25 skipped 0.34 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 472.08 0.90-5.00 402.70 -14.70 FAILED median 532.23 skipped 381.42 SKIP dev 106.68 skipped 128.34 SKIP cv 0.23 skipped 0.32 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS string interface (short seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 61.43 skipped 62.22 SKIP median 60.59 skipped 62.37 SKIP dev 3.69 skipped 3.74 SKIP cv 0.06 skipped 0.06 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 77.84 0.90-5.00 76.85 -1.28 OK median 78.69 skipped 76.45 SKIP dev 4.50 skipped 4.50 SKIP cv 0.06 skipped 0.06 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS string interface (long seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 39.14 skipped 39.38 SKIP median 36.45 skipped 37.38 SKIP dev 4.36 skipped 3.44 SKIP cv 0.11 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 122.96 0.90-5.00 121.77 -0.97 OK median 130.82 skipped 127.56 SKIP dev 12.80 skipped 9.99 SKIP cv 0.10 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS class interface (short seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 44.30 skipped 44.31 SKIP median 43.55 skipped 43.55 SKIP dev 3.32 skipped 3.15 SKIP cv 0.08 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 108.09 0.90-5.00 108.04 -0.05 OK median 109.50 skipped 109.49 SKIP dev 7.73 skipped 7.33 SKIP cv 0.07 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS class interface (long seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 12.74 skipped 13.02 SKIP median 11.33 skipped 11.21 SKIP dev 2.70 skipped 2.86 SKIP cv 0.21 skipped 0.22 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 386.56 0.90-5.00 379.34 -1.87 OK median 421.01 skipped 425.53 SKIP dev 73.70 skipped 74.71 SKIP cv 0.19 skipped 0.20 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/Terminal.benchmark.js|Terminal: ls -lR /usr/lib|write/string/async|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 5.35 skipped 6.30 SKIP median 3.41 skipped 3.72 SKIP dev 4.04 skipped 4.96 SKIP cv 0.75 skipped 0.79 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 9.94 0.75-1.50 9.14 -8.03 OK median 10.29 skipped 9.43 SKIP dev 6.04 skipped 6.00 SKIP cv 0.61 skipped 0.66 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/Terminal.benchmark.js|Terminal: ls -lR /usr/lib|write/Utf8/async|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 2.56 skipped 3.26 SKIP median 2.59 skipped 3.63 SKIP dev 0.45 skipped 1.20 SKIP cv 0.18 skipped 0.37 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 14.07 0.75-1.50 12.15 -13.63 OK median 13.55 skipped 9.68 SKIP dev 2.52 skipped 4.74 SKIP cv 0.18 skipped 0.39 SKIP runs 5.00 skipped 5.00 SKIP

Success: 17
Missing: 0
Skipped: 162
Failed: 1
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

 Success: 17
 Missing: 0
 Skipped: 162
 Failed: 1

Tyriar · 2024-07-14T16:02:56Z

src/common/InputHandler.ts

+  private readonly _onRequestBell = this.register(new Emitter<void>());
  public readonly onRequestBell = this._onRequestBell.event;
-  private readonly _onRequestRefreshRows = this.register(new EventEmitter<number, number>());
+  private readonly _onRequestRefreshRows = this.register(new Emitter<{ start: number, end: number }>());


Benchmark regression likely due to this

Tyriar · 2024-07-14T16:05:48Z

All passing after bd700fe

Details

yarn run v1.22.21 $ NODE_PATH=./out xterm-benchmark -r 5 -c test/benchmark/benchmark.json --eval out-test/benchmark/*benchmark.js Context "out-test/benchmark/EscapeSequenceParser.benchmark.js" Context "Parser throughput - 50MB data" Context "PRINT - a" Case "#1" : 5 runs - average throughput: 841.09 MB/s Context "EXECUTE - \n" Case "#1" : 5 runs - average throughput: 189.35 MB/s Context "ESCAPE - ESC E" Case "#1" : 5 runs - average throughput: 74.45 MB/s Context "ESCAPE with collect - ESC % G" Case "#1" : 5 runs - average throughput: 97.42 MB/s Context "CSI - CSI A" Case "#1" : 5 runs - average throughput: 137.95 MB/s Context "CSI with collect - CSI ? p" Case "#1" : 5 runs - average throughput: 152.41 MB/s Context "CSI with params (short) - CSI 1;2 m" Case "#1" : 5 runs - average throughput: 167.09 MB/s Context "CSI with params (long) - CSI 1;2;3;4;5;6;7;8;9;0 m" Case "#1" : 5 runs - average throughput: 242.81 MB/s Context "OSC string interface (short seq) - OSC 0;hi ST" Case "#1" : 5 runs - average throughput: 103.27 MB/s Context "OSC string interface (long seq) - OSC 0; ST" Case "#1" : 5 runs - average throughput: 133.66 MB/s Context "OSC class interface (short seq) - OSC 0;hi ST" Case "#1" : 5 runs - average throughput: 135.52 MB/s Context "OSC class interface (long seq) - OSC 0; ST" Case "#1" : 5 runs - average throughput: 477.29 MB/s Context "DCS string interface (short seq)" Case "#1" : 5 runs - average throughput: 76.96 MB/s Context "DCS string interface (long seq)" Case "#1" : 5 runs - average throughput: 124.41 MB/s Context "DCS class interface (short seq)" Case "#1" : 5 runs - average throughput: 109.49 MB/s Context "DCS class interface (long seq)" Case "#1" : 5 runs - average throughput: 385.66 MB/s Context "out-test/benchmark/Terminal.benchmark.js" Context "Terminal: ls -lR /usr/lib" Context "write/string/async" Case "#1" : 5 runs - average throughput: 9.75 MB/s Context "write/Utf8/async" Case "#1" : 5 runs - average throughput: 13.50 MB/s "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|PRINT - a|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 6.66 skipped 6.86 SKIP median 5.10 skipped 5.44 SKIP dev 3.34 skipped 3.37 SKIP cv 0.50 skipped 0.49 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 871.35 0.90-5.00 841.09 -3.47 OK median 934.79 skipped 876.61 SKIP dev 392.95 skipped 378.23 SKIP cv 0.45 skipped 0.45 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|EXECUTE - \n|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 25.30 skipped 25.48 SKIP median 23.67 skipped 24.36 SKIP dev 3.18 skipped 3.14 SKIP cv 0.13 skipped 0.12 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 190.67 0.90-5.00 189.35 -0.69 OK median 201.48 skipped 195.72 SKIP dev 22.20 skipped 22.44 SKIP cv 0.12 skipped 0.12 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|ESCAPE - ESC E|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 64.56 skipped 64.10 SKIP median 65.35 skipped 63.07 SKIP dev 1.28 skipped 2.00 SKIP cv 0.02 skipped 0.03 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 73.88 0.90-5.00 74.45 0.77 OK median 72.97 skipped 75.60 SKIP dev 1.48 skipped 2.27 SKIP cv 0.02 skipped 0.03 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|ESCAPE with collect - ESC % G|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 54.92 skipped 48.99 SKIP median 54.68 skipped 48.39 SKIP dev 0.86 skipped 1.77 SKIP cv 0.02 skipped 0.04 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 86.83 0.90-5.00 97.42 12.20 OK median 87.21 skipped 98.54 SKIP dev 1.35 skipped 3.45 SKIP cv 0.02 skipped 0.04 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI - CSI A|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.31 skipped 34.71 SKIP median 35.83 skipped 33.84 SKIP dev 1.90 skipped 2.56 SKIP cv 0.05 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 135.37 0.90-5.00 137.95 1.90 OK median 133.08 skipped 140.91 SKIP dev 7.39 skipped 9.73 SKIP cv 0.05 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with collect - CSI ? p|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 31.50 skipped 31.43 SKIP median 31.00 skipped 30.33 SKIP dev 1.70 skipped 2.49 SKIP cv 0.05 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 151.72 0.90-5.00 152.41 0.45 OK median 153.84 skipped 157.20 SKIP dev 8.06 skipped 11.18 SKIP cv 0.05 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with params (short) - CSI 1;2 m|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 28.52 skipped 28.78 SKIP median 28.07 skipped 28.16 SKIP dev 3.39 skipped 3.05 SKIP cv 0.12 skipped 0.11 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 168.93 0.90-5.00 167.09 -1.09 OK median 169.88 skipped 169.36 SKIP dev 18.02 skipped 16.71 SKIP cv 0.11 skipped 0.10 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|CSI with params (long) - CSI 1;2;3;4;5;6;7;8;9;0 m|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 19.84 skipped 19.90 SKIP median 19.93 skipped 19.32 SKIP dev 2.45 skipped 2.69 SKIP cv 0.12 skipped 0.14 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 243.09 0.90-5.00 242.81 -0.12 OK median 239.22 skipped 246.80 SKIP dev 27.94 skipped 29.43 SKIP cv 0.11 skipped 0.12 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC string interface (short seq) - OSC 0;hi ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 45.32 skipped 46.36 SKIP median 43.34 skipped 44.68 SKIP dev 3.28 skipped 3.37 SKIP cv 0.07 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 105.63 0.90-5.00 103.27 -2.23 OK median 110.03 skipped 106.72 SKIP dev 7.23 skipped 7.02 SKIP cv 0.07 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC string interface (long seq) - OSC 0; ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.52 skipped 35.95 SKIP median 33.44 skipped 33.78 SKIP dev 3.34 skipped 3.63 SKIP cv 0.09 skipped 0.10 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 135.14 0.90-5.00 133.66 -1.09 OK median 142.61 skipped 141.15 SKIP dev 12.05 skipped 12.53 SKIP cv 0.09 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC class interface (short seq) - OSC 0;hi ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 35.18 skipped 35.43 SKIP median 34.46 skipped 33.62 SKIP dev 3.09 skipped 3.46 SKIP cv 0.09 skipped 0.10 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 136.33 0.90-5.00 135.52 -0.59 OK median 138.36 skipped 141.84 SKIP dev 11.31 skipped 11.98 SKIP cv 0.08 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|OSC class interface (long seq) - OSC 0; ST|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 10.59 skipped 10.49 SKIP median 8.96 skipped 8.74 SKIP dev 2.69 skipped 2.76 SKIP cv 0.25 skipped 0.26 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 472.08 0.90-5.00 477.29 1.10 OK median 532.23 skipped 545.32 SKIP dev 106.68 skipped 109.73 SKIP cv 0.23 skipped 0.23 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS string interface (short seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 61.43 skipped 62.19 SKIP median 60.59 skipped 62.36 SKIP dev 3.69 skipped 4.28 SKIP cv 0.06 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 77.84 0.90-5.00 76.96 -1.14 OK median 78.69 skipped 76.46 SKIP dev 4.50 skipped 5.17 SKIP cv 0.06 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS string interface (long seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 39.14 skipped 38.54 SKIP median 36.45 skipped 36.64 SKIP dev 4.36 skipped 3.31 SKIP cv 0.11 skipped 0.09 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 122.96 0.90-5.00 124.41 1.18 OK median 130.82 skipped 130.14 SKIP dev 12.80 skipped 10.00 SKIP cv 0.10 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS class interface (short seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 44.30 skipped 43.75 SKIP median 43.55 skipped 43.01 SKIP dev 3.32 skipped 3.35 SKIP cv 0.08 skipped 0.08 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 108.09 0.90-5.00 109.49 1.30 OK median 109.50 skipped 110.86 SKIP dev 7.73 skipped 8.00 SKIP cv 0.07 skipped 0.07 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/EscapeSequenceParser.benchmark.js|Parser throughput - 50MB data|DCS class interface (long seq)|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 12.74 skipped 12.78 SKIP median 11.33 skipped 10.97 SKIP dev 2.70 skipped 2.77 SKIP cv 0.21 skipped 0.22 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 386.56 0.90-5.00 385.66 -0.23 OK median 421.01 skipped 434.65 SKIP dev 73.70 skipped 73.35 SKIP cv 0.19 skipped 0.19 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/Terminal.benchmark.js|Terminal: ls -lR /usr/lib|write/string/async|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 5.35 skipped 5.34 SKIP median 3.41 skipped 3.49 SKIP dev 4.04 skipped 3.84 SKIP cv 0.75 skipped 0.72 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 9.94 0.75-1.50 9.75 -1.89 OK median 10.29 skipped 10.07 SKIP dev 6.04 skipped 5.85 SKIP cv 0.61 skipped 0.60 SKIP runs 5.00 skipped 5.00 SKIP "out-test/benchmark/Terminal.benchmark.js|Terminal: ls -lR /usr/lib|write/Utf8/async|#1" #averageRuntime - skipped STAT BASE TOLERANCE VALUE EVAL mean 2.56 skipped 2.85 SKIP median 2.59 skipped 3.06 SKIP dev 0.45 skipped 0.95 SKIP cv 0.18 skipped 0.33 SKIP runs 5.00 skipped 5.00 SKIP #averageThroughput STAT BASE TOLERANCE VALUE CHANGE(%) EVAL mean 14.07 0.75-1.50 13.50 -4.04 OK median 13.55 skipped 11.46 SKIP dev 2.52 skipped 4.47 SKIP cv 0.18 skipped 0.33 SKIP runs 5.00 skipped 5.00 SKIP

Success: 18
Missing: 0
Skipped: 162
Failed: 0

 Success: 18
 Missing: 0
 Skipped: 162
 Failed: 0

Tyriar added 5 commits July 14, 2024 07:41

Add load test for long lines

9187cd3

Migrate most EventEmitter to base/ Emitter

90ff6f3

Migrate rest of EventEmitter to base/ Emitter

9141b52

Remove IEvent and runAndSubscribe

9c7e2ea

Move forwardEvent to Events.ts

e267f05

Tyriar added this to the 5.6.0 milestone Jul 14, 2024

Tyriar self-assigned this Jul 14, 2024

Tyriar added 8 commits July 14, 2024 08:30

Add vs project to headless tsconfig

26c73b8

Add vs alias to headless webpack config

10b97f4

Add vs resolve to addons

68e0eb7

Add forward to Event

460a137

Remove Events.ts in favor of new Event.forward

ae8f2dd

Fix addon resolve path

03c2b2f

Import right path in addons

618954b

Fix benchmark npm script

b6b19ba

Tyriar commented Jul 14, 2024

View reviewed changes

Allow refreshing all rows without creating object

bd700fe

Resolve vs in unicode11

180fd3c

Tyriar marked this pull request as ready for review July 14, 2024 16:19

Tyriar merged commit 060ce7a into xtermjs:master Jul 14, 2024

Tyriar modified the milestones: 5.6.0, 6.0.0 Jul 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove EventEmitter in favor of vs/base/common/event's Emitter#5104

Remove EventEmitter in favor of vs/base/common/event's Emitter#5104
Tyriar merged 15 commits intoxtermjs:masterfrom
Tyriar:tyriar/events

Tyriar commented Jul 14, 2024 •

edited

Loading

Uh oh!

Tyriar commented Jul 14, 2024 •

edited

Loading

Uh oh!

Tyriar Jul 14, 2024

Uh oh!

Tyriar commented Jul 14, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Tyriar commented Jul 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tyriar commented Jul 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tyriar Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

Tyriar commented Jul 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Tyriar commented Jul 14, 2024 •

edited

Loading

Tyriar commented Jul 14, 2024 •

edited

Loading

Tyriar commented Jul 14, 2024 •

edited

Loading