Include base/ platform from VS Code, adopt DomScrollableElement and introduce esbuild#5077
Closed
Tyriar wants to merge 41 commits intoxtermjs:masterfrom
Closed
Include base/ platform from VS Code, adopt DomScrollableElement and introduce esbuild#5077Tyriar wants to merge 41 commits intoxtermjs:masterfrom
Tyriar wants to merge 41 commits intoxtermjs:masterfrom
Conversation
8 tasks
These aren't very important and task up too much space
Member
Author
|
I stopped this briefly to work on some debt and to bring some of the changes here into Here is the current
And the current output usage on this branch (I think):
|
Member
Author
|
Proposal (probably needs a different PR):
|
Member
|
@Tyriar Plz just ping me, if you think this is ready to have a look from my side. Seems there are still some merge conflicts from your ESM transition, and I dont want to interfere in the middle of that transition to not over-complicate things. |
Member
Author
|
@jerch yep planning on closing and redoing this PR today, the next one will be significantly smaller (ignoring |
Member
Author
|
Closing in favor of #5096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Succeeds #5076