Speed up clearing all markers, mass event listener dispose#5066
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Jun 3, 2024
Merged
Speed up clearing all markers, mass event listener dispose#5066Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
mofux
reviewed
Jun 3, 2024
|
|
||
| export class EventEmitter<T, U = void> implements IEventEmitter<T, U> { | ||
| private _listeners: IListener<T, U>[] = []; | ||
| private _listeners: Set<IListener<T, U>> = new Set(); |
Contributor
There was a problem hiding this comment.
@Tyriar Just a remark, I think this could theoretically introduce a bug: if you add the same listener function more than once. The Set will filter out duplicate references, so registering the same listener callback function twice will now only fire the listener once. I don't think this will be a problem in practice because listener callbacks are most likely passed as anonymous callback functions anyway, but yeah. Just saying :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of microsoft/vscode#213174
Part of microsoft/vscode#213304
Test: 1000 scrollback, decorations stress test
Before:
After: