Add powerline git, LN, lock symbols#5054
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Jun 3, 2024
Merged
Conversation
Symbols taken from https://github.com/powerline/fontpatcher/blob/develop/fonts/powerline-symbols.sfd The original symbols use height and widith of approx 1060x2048, so I modified to be roughly 1000x1000 via: fontforge -lang=ff -c 'Open($1); SelectAll(); UnlinkReference(); Scale(100, 50); Move(0, 300); Export("svg/%n-%e.svg");' powerline-symbols.sfd Then I edited by hand to round values to approx 2 significant digits, and then used a script to convert relative SVG commands such as 'l', 'c', 's' to use only 'M', 'L' and 'C' and used expected format with comma separators rather than spaces, and divide all values by 1000 to map into a 1x1 space.
Author
Author
|
@meganrogge @sbatten who have committed to CustomGlyph.ts in the past |
Member
|
@joelhockey Imho @Tyriar wrote the custom glyph handling code, so he might be best to review it. |
Tyriar
approved these changes
Jun 3, 2024
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
This is fantastic! 👏
Zoomed:
Big letter spacing and line height:
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbols taken from https://github.com/powerline/fontpatcher/blob/develop/fonts/powerline-symbols.sfd
The original symbols use height and widith of approx 1060x2048, so I modified to be roughly 1000x1000 via:
fontforge -lang=ff -c 'Open($1); SelectAll(); UnlinkReference(); Scale(100, 50); Move(0, 300); Export("svg/%n-%e.svg");' powerline-symbols.sfd
Then I edited by hand to round values to approx 2 significant digits, and then used a script to convert relative SVG commands such as 'l', 'c', 's' to use only 'M', 'L' and 'C' and used expected format with comma separators rather than spaces, and divide all values by 1000 to map into a 1x1 space.