Skip to content

Fix duplicate input for some IMEs#5024

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
ksqsf:master
Apr 8, 2024
Merged

Fix duplicate input for some IMEs#5024
Tyriar merged 1 commit intoxtermjs:masterfrom
ksqsf:master

Conversation

@ksqsf
Copy link
Copy Markdown
Contributor

@ksqsf ksqsf commented Apr 8, 2024

This is a simple fix for #5023 by removing the assumption "the end position is stable". Instead, it uses the start position of the new composition as the end position of the previous composition.

fixes #5023

Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tyriar Tyriar self-assigned this Apr 8, 2024
@Tyriar Tyriar added this to the 5.6.0 milestone Apr 8, 2024
@Tyriar Tyriar enabled auto-merge April 8, 2024 12:49
@Tyriar Tyriar merged commit 887e5a6 into xtermjs:master Apr 8, 2024
@Tyriar Tyriar modified the milestones: 5.6.0, 6.0.0 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate input when using Chinese input methods

2 participants