Update global object fix#4940
Merged
Tyriar merged 18 commits intoxtermjs:masterfrom Apr 21, 2024
octoclonius:patch-1
Merged
Conversation
`this` might be okay, I'm not actually sure, but xterm.js uses `globalThis` and so I think consistency is better maybe?
ManojkumarV
approved these changes
Feb 7, 2024
|
Is there any progress on this PR? I am also troubled by this problem, recompiling addon after using this patch works fine for me. |
|
@Tyriar Do you think this PR is something that could be merged in nearest future? Is anything needed here to unblock it? It's blocking usage of the library with nuxt (in SSR context it tends to fail). |
Tyriar
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are to the
webpack.config.jsfiles in each of the addon's folders. I set the global object toglobalThis. I think this should fix the addons because when I import them, I get an error sayingselfis not defined.