fix url parsing for urls with percentage sign in them#4937
Merged
jerch merged 2 commits intoxtermjs:masterfrom Jan 11, 2024
Merged
fix url parsing for urls with percentage sign in them#4937jerch merged 2 commits intoxtermjs:masterfrom
jerch merged 2 commits intoxtermjs:masterfrom
Conversation
jerch
suggested changes
Jan 5, 2024
Member
jerch
left a comment
jerch
left a comment
There was a problem hiding this comment.
LGTM, just a minor nitpick from my side below.
| @@ -64,8 +76,7 @@ export class LinkComputer { | |||
| // - append / also match domain urls w'o any path notion | |||
Member
There was a problem hiding this comment.
Can you also edit the comment to reflect the code, e.g. remove the listing and mention the explicit equality testing up to the host part.
Contributor
Author
There was a problem hiding this comment.
updated the comment, lmk what you think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue outline and discussed in here #4934