Skip to content

Update required eslint and eslint-plugin-jsdoc versions#4930

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
PerBothner:update-eslint
Dec 30, 2023
Merged

Update required eslint and eslint-plugin-jsdoc versions#4930
Tyriar merged 1 commit intoxtermjs:masterfrom
PerBothner:update-eslint

Conversation

@PerBothner
Copy link
Copy Markdown
Contributor

@PerBothner PerBothner commented Dec 30, 2023 •
edited
Loading

This fixes a problem when using node 20.x.x, because [email protected] requires node version "^14 || ^16 || ^17 || ^18 || ^19".

$ node --version
v20.10.0
$ yarn
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
error [email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.10.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@PerBothner
Update required eslint and eslint-plugin-jsdoc versions
a7bf3b2 
This fixes a problem when using node 20.*.*, because [email protected]
requires node version "^14 || ^16 || ^17 || ^18 || ^19".
@Tyriar Tyriar added this to the 5.4.0 milestone Dec 30, 2023
@Tyriar Tyriar merged commit b97baa7 into xtermjs:master Dec 30, 2023
@PerBothner PerBothner deleted the update-eslint branch December 30, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PerBothner @Tyriar