Merged
Conversation
silamon
approved these changes
Oct 9, 2023
Contributor
silamon
left a comment
silamon
left a comment
There was a problem hiding this comment.
It's possible that it wasn't tested during initial implementation. Thanks for the fix.
includeGlobalBackground uses the configured foreground and background of the terminal. When false it defaults to black color and white background indeed. I kind of agree it can be improved.
Tyriar
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may be missing something, but it looks like the
#character is missing from the generated colors, so the HTML serialization doesn't work.edit: Unrelated but also weird,
includeGlobalBackgroundactually still include a background, except that it's hardcoded to a white background. It probably should just skip assigning the global styles?