Correct graphemes addon readme and typings#4809
Merged
Tyriar merged 2 commits intoxtermjs:masterfrom Sep 16, 2023
silamon:correct-typing-graphemes
Merged
Correct graphemes addon readme and typings#4809Tyriar merged 2 commits intoxtermjs:masterfrom silamon:correct-typing-graphemes
Tyriar merged 2 commits intoxtermjs:masterfrom
silamon:correct-typing-graphemes
Conversation
silamon
changed the title
Contributor
|
I'm OK with these changes. One might argue that it is confusing to use singular "Grapheme" in |
Tyriar
approved these changes
Sep 16, 2023
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
LGTM
For UnicodeGraphemeProvider using singular isn't a big deal as it's an internal file, I guess making it consistently plural would be better though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small copy-paste fix for the typings file and readme file in the new graphemes addon.