Skip to content

Move WidthCache measure container to helper container#4807

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
mofux:isolate-width-cache-element
Sep 15, 2023
Merged

Move WidthCache measure container to helper container#4807
Tyriar merged 1 commit intoxtermjs:masterfrom
mofux:isolate-width-cache-element

Conversation

@mofux
Copy link
Copy Markdown
Contributor

@mofux mofux commented Sep 15, 2023 •
edited
Loading

Fixes #4806
Fixes #4805

  • Moves the WidthCache measure container into the Terminal's helper container .xterm-helpers (analog to DomMeasureStrategy used by the CharSizeService)
  • The spans used for the different measurements now also use the xterm-char-measure-element class, which makes sure that those elements are not visible (visibility: hidden).
  • Uses the document reference of the terminal (which refers to the ownerDocument of the terminal element). This makes sure we use the correct document reference when creating DOM elements.

Tested against latest Chrome and Firefox on Linux

@mofux mofux requested review from Tyriar and jerch September 15, 2023 09:15
Tyriar
Tyriar approved these changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @jerch could you give this a look too?

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 15, 2023
@Tyriar Tyriar self-assigned this Sep 15, 2023
jerch
jerch approved these changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @mofux.

Regarding the global WidthCache handling we prolly have to rework things here, but lets keep that for an actual PR dealing with this.

@Tyriar Tyriar merged commit a6f5726 into xtermjs:master Sep 15, 2023
@jayarjo
Copy link
Copy Markdown

jayarjo commented Oct 23, 2023

Is this fix merged and released yet? Observing overflow problem in Chrome on Mac.

@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Oct 23, 2023

@jayarjo not in stable, you can use the beta build to get this fix

@david-crespo david-crespo mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

+1 more reviewer

@jerch jerch jerch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

WidthCache is added document.body, it should be a child of .xterm-helpers ideally WidthCache causing horizontal overflow (scrolling)

4 participants

@mofux @jayarjo @Tyriar @jerch