DomRenderer draw selection inactive background correctly when unfocused#4763
Merged
Tyriar merged 9 commits intoxtermjs:masterfrom Sep 9, 2023
Merged
Conversation
There's too many theme colors, we'll leave it to the console
Tyriar
approved these changes
Sep 9, 2023
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Fix works 👍
I reverted the demo parts as there's too many theme keys to do that (though we may add theme customization to the options tab at some point). I did set the default value for the inactive theme key to the default theme though.
Member
|
Added a regression test |
Contributor
Author
|
I also try the playwright test. |
Tyriar
changed the title
Tyriar
force-pushed
the
fix-selection-background-domrenderer
branch
from
fa1356c to
a101135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4750.