Merged
Conversation
Tyriar
approved these changes
Aug 25, 2023
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Not sure how to go about xterm-wasm-parts - we can move it over into xtermjs group, or leave at my site (hopefully the inwasm patches dont take too long...)
It's fine as is since it's just temporary
Member
Author
Well just give a ping, if it raises security concerns on your end. Then we prolly should put it fully under the xtermjs group umbrella. (e.g. also the npm releasing and such). |
Member
|
We should see any changes to the npm package going in, the only risk should be if the yarn.lock changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
inwasmstill creates too much fuss at various ends, I removed it until it is in better shape.@Tyriar Not sure how to go about xterm-wasm-parts - we can move it over into xtermjs group, or leave at my site (hopefully the
inwasmpatches dont take too long...)Fixes #4720, fixes #4646.