Make GH actions strategy more concise#4700
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Aug 19, 2023
Merged
Conversation
Member
Author
|
@jerch think I'm done with the CI changes. It's much faster now and I also reduced the number of required checks to speed up merging. If we happen to get failing tests merged in we should notice pretty quickly. |
Member
|
@Tyriar Is that down from ~14m to ~8m? Wow the unit tests complete faster in gh-actions (26s) than on my machine (28s) 😍 Great work! |
Member
Author
|
It'll vary but the slowest job we wait for now are unit tests on Windows, so this one took about 8 minutes to finish required checks, 11 minutes to finish all checks. Then when it hits master, we release immediately so this took 3 minutes to release as opposed to the ~15 |
Member
Author
|
Oh also, we now must run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.