Workaround crash that can happen in Electron/Chromium#4678
Workaround crash that can happen in Electron/Chromium#4678Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
|
Eww, is this style element handling browser-alpha ground? Tbh I dont like where this is going - should we revert the style stuff to a more proven code pattern? On a sidenote - not even sure how recent engines need to be to support this - did we just raise the version requirements to newest browsers only by adding by #4611? Edit: |
|
We can now actually reproduce this in Chromium, so I'm also thinking we should just revert the whole CSP change as it doesn't seem like it's ready for primetime. FYI @SimonSiefke |
|
Sorry for the breakage caused by my changes. I also agree that reverting the changes is the best option!
The change uses try/catch and falls back to |
Part of microsoft/vscode#189753
cc @deepak1556