update typescript version to 5.1.6#4612
update typescript version to 5.1.6#4612Tyriar merged 4 commits intoxtermjs:masterfrom SimonSiefke:update-typescript-version
Conversation
src/browser/Viewport.ts
Outdated
| @IRenderService private readonly _renderService: IRenderService, | ||
| @ICoreBrowserService private readonly _coreBrowserService: ICoreBrowserService, | ||
| @IThemeService themeService: IThemeService | ||
| @IThemeService public themeService: IThemeService |
There was a problem hiding this comment.
Why were these publics added? They aren't needed as properties, only ctor args
There was a problem hiding this comment.
For some reason ESLint was showing a warning Missing accessibility modifier on parameter property themeService, so I just added public and it kind of worked.
What do you think would be the best way to fix this?
There was a problem hiding this comment.
That's weird as we explicitly say don't consider constructors:
Lines 62 to 70 in b4aeb1b
We might need to update eslint, @typescript-eslint and/or that rule to be compatible with the new TS version?
There was a problem hiding this comment.
That worked! I updated eslint, @typescript-eslint/eslint-plugin and @typescript-eslint/parser to the latest version.
3 participants
required for CssStyleSheet typings needed in #4611