I updated the branch

This seems to make the Linux/Firefox integration tests consistently fail. You can run these with npm run test-api-firefox

Fixed! :)

@SimonSiefke Can you plz also check, that replaceSync does not create another forced layouting step, the last thing we need in the DOM renderer is additional render engine work. So the question here is, if that sync in the name means sync to DOM render state.

@jerch I get the impression replaceSync is doing what we used to do and replace would batch it for later if it isn't needed immediately like in our tests. But regardless, even slightly slower here shouldn't matter as it's only on dimensions change (not resize) and changing theme which seldom happens. I double checked the time by resizing a few times on my macbook:

@jerch As far as I understand, there is no extra synchronization in replaceSync, it is just the synchronous version of replace

Can you plz also check, that replaceSync does not create another forced layouting step

As @Tyriar said, it is basically the same, both methods are dom writes, there are no extra forced layouts with this method.

Perhaps performance might even be slightly better because there are two less dom elements now, which is also something but I doubt it would make a huge difference.

@SimonSiefke thanks again, this was a great change as I know several people have hit the CSP issue

I stumbled over one aspect in this PR when merging the DOM renderer PR with master - in StyleSheet.ts the global document is accessed. In an older PR we abstracted document into a terminal setting to make popouts into other documents working, as some functionality is bound to the real underlying document.

Question - should the code in StyleSheet.ts also refer to our document variable or does it not matter here? Note I had a similar case with cross document canvas painting, but it just works for those across documents.

@jerch good find, I'll fix it up

6.0.0 still relies on inline styles. A previous fix was reverted upstream, so this is a known limitation. Is there any recommended workaround or planned fix to avoid requiring style-src 'unsafe-inline'?