Skip to content

Add getRasterizedGlyph null and undefined check#4596

Merged
Tyriar merged 2 commits intoxtermjs:masterfrom
lewis-sanchez:lewissanchez/bug/rasterized-glyph-undefined
Jul 16, 2023
Merged

Add getRasterizedGlyph null and undefined check#4596
Tyriar merged 2 commits intoxtermjs:masterfrom
lewis-sanchez:lewissanchez/bug/rasterized-glyph-undefined

Conversation

@lewis-sanchez
Copy link
Copy Markdown
Contributor

@lewis-sanchez lewis-sanchez commented Jul 14, 2023

Ensures that the charAtlas object is not undefined or null before getRasterizedGlyph is invoked.

This PR fixes #4560

@lewis-sanchez lewis-sanchez marked this pull request as draft July 14, 2023 20:00
@lewis-sanchez lewis-sanchez marked this pull request as ready for review July 14, 2023 23:59
@Tyriar
Copy link
Copy Markdown
Member

Tyriar commented Jul 16, 2023

Thanks!

@Tyriar Tyriar added this to the 5.3.0 milestone Jul 16, 2023
@Tyriar Tyriar self-assigned this Jul 16, 2023
@Tyriar Tyriar merged commit 53d1057 into xtermjs:master Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Cannot read properties of undefined (reading 'getRasterizedGlyph')" when a target element is not displayed

2 participants