use border-bottom instead of box-shadow for underline cursor#4584
Merged
jerch merged 1 commit intoxtermjs:masterfrom Aug 1, 2023
Merged
use border-bottom instead of box-shadow for underline cursor#4584jerch merged 1 commit intoxtermjs:masterfrom
jerch merged 1 commit intoxtermjs:masterfrom
Conversation
In rare cases, box-shadow can cause aliasing artifacts on the top and sides of the cursor box when only the bottom should be filled in to create an underline. This replaces the box-shadow style with border-bottom which should be pixel perfect in all cases. Fixes: xtermjs#4580
dlech
force-pushed
the
fix-underline-style
branch
from
e881281 to
9663429
Compare
Member
Member
Member
|
Can't remember... Maybe just to ensure it stays within the cell? |
jerch
approved these changes
Aug 1, 2023
Member
jerch
left a comment
jerch
left a comment
There was a problem hiding this comment.
Tested several zoom level (dpr changes) and font sizes - renders crisper than the old approach for certain settings. Could not find any glitch either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases, box-shadow can cause aliasing artifacts on the top and sides of the cursor box when only the bottom should be filled in to create an underline.
This replaces the box-shadow style with border-bottom which should be pixel perfect in all cases.
Fixes: #4580