Render the cursor in the WebGL canvas#4568
Merged
Tyriar merged 9 commits intoxtermjs:masterfrom Aug 1, 2023
Merged
Conversation
This also focused the manager's creation on renderer start up, to ensure blink works immediately.
Member
Member
|
Underline and bar cursors don't seem to update correctly atm |
Member
Member
|
Fixed the blue problem, was related to rgba format being used as rgb f64cb15 |
Member
|
The light theme issue is actually a problem outside of this PR as the cursor colors don't get set in the theme so the defaults are used. |
This was referenced Aug 1, 2023
This ensures underline/bar cursors get rendered
Member
|
Just need to fix the tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#4082
The
RectangleRendereris updated not just to draw cell backgrounds, but the cursor as well (barandunderscorecursors are 1px wide rectangles,blurcursor consists of four 1px rectangles). The block cursor is implemented by changing cell attributes.The
CursorRenderLayeris dropped.