Add more granular windowsPty option#4539
Merged
Tyriar merged 4 commits intoxtermjs:masterfrom Jun 7, 2023
Merged
Conversation
Member
Author
|
Will push this and adopt in VS Code in a week or so when we branch off the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: microsoft/vscode#134448
This adds a new option
windowsPtythat replaces/deprecateswindowsOption. It gives more granularity around the backend pty info on Windows as enabling heuristics/workarounds is more that just a simple flag now that certain things have been fixed in ConPTY.