Skip to content

Cleanup Buffer.ts#4335

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
jerch:cleanup_buffer
Dec 20, 2022
Merged

Cleanup Buffer.ts#4335
Tyriar merged 1 commit intoxtermjs:masterfrom
jerch:cleanup_buffer

Conversation

@jerch
Copy link
Copy Markdown
Member

@jerch jerch commented Dec 19, 2022

Fixes #4331.

@Tyriar Tyriar added this to the 5.2.0 milestone Dec 20, 2022
Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like deleted code 🎉

@Tyriar Tyriar merged commit 3142460 into xtermjs:master Dec 20, 2022
@jerch
Copy link
Copy Markdown
Member Author

jerch commented Dec 20, 2022

I like deleted code 🎉

rm -rf / is your friend 🙈
(Seriously - happened to me once in the past on a remote server connection, and I think the keyboard got bite marks from that incident. So yeah backups are a pretty decent thing, if you have one 🤣)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Buffer.iterator

2 participants