Send corresponding escape code for alt+space and ctrl+alt+space#4290
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Dec 7, 2022
Merged
Send corresponding escape code for alt+space and ctrl+alt+space#4290Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
The previous behavior is that this combinations do nothing.
Author
|
Thew new behavior matches what gnome-terminal and hterm do. |
jerch
approved these changes
Dec 7, 2022
Member
jerch
left a comment
jerch
left a comment
There was a problem hiding this comment.
Yes looks correct to me. I cannot really test any of them, as my window manager eats those combinations. But the basic idea of the Alt+mechanics is correct: send byte value of the pressed keys with ESC prepended:
- "space" --->
0x20==SP - "alt-space" -->
0x1b20==ESC SP - "ctrl-space" --->
0x00==NUL - "alt-ctrl-space" --->
0x1b00==ESC NUL
So I'd give this a go until someone claims, thats not the right Alt expansion for that particular key combinations.
Tyriar
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior is that this combinations do nothing.