Warn/throw on unexpected attach addon socket state#4208
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Oct 17, 2022
Merged
Warn/throw on unexpected attach addon socket state#4208Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
jerch
approved these changes
Oct 16, 2022
Member
jerch
left a comment
jerch
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment on CLOSING.
| throw new Error('Attach addon was loaded before socket was open'); | ||
| case WebSocket.CLOSING: | ||
| console.warn('Attach addon socket is closing'); | ||
| return false; |
Member
There was a problem hiding this comment.
Why not throwing here as well? Would this create race conditions during app shutdown?
Member
Author
There was a problem hiding this comment.
Was worried about breaking something as we dispose on 'close', not closing. Probably doesn't matter 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jerch fixing a random TODO, does this seem reasonable?