Skip to content

Improve names of IRenderDimensions interface members#4207

Merged
Tyriar merged 10 commits intoxtermjs:masterfrom
Tyriar:3925_dimensions
Oct 16, 2022
Merged

Improve names of IRenderDimensions interface members#4207
Tyriar merged 10 commits intoxtermjs:masterfrom
Tyriar:3925_dimensions

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Oct 16, 2022

Fixes #3925

Before:

export interface IRenderDimensions {
  scaledCharWidth: number;
  scaledCharHeight: number;
  scaledCellWidth: number;
  scaledCellHeight: number;
  scaledCharLeft: number;
  scaledCharTop: number;
  scaledCanvasWidth: number;
  scaledCanvasHeight: number;
  canvasWidth: number;
  canvasHeight: number;
  actualCellWidth: number;
  actualCellHeight: number;
}

After:

export interface IRenderDimensions {
  css: {
    canvas: IDimensions; // previously: canvas*
    cell: IDimensions; // previously: actualCell*
  };
  device: { // previously: scaled*
    canvas: IDimensions;
    cell: IDimensions;
    char: IDimensions & IOffset;
  };
}

@Tyriar Tyriar added this to the 5.1.0 milestone Oct 16, 2022
@Tyriar Tyriar self-assigned this Oct 16, 2022
@Tyriar Tyriar enabled auto-merge October 16, 2022 01:08
@Tyriar Tyriar merged commit 807183b into xtermjs:master Oct 16, 2022
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 19, 2022
@Tyriar Tyriar deleted the 3925_dimensions branch October 19, 2022 12:31
meganrogge pushed a commit to microsoft/vscode that referenced this pull request Oct 19, 2022
* Revert "Revert "Update xterm.js" (#164002)"

This reverts commit 462ecfa.

* Adopt xterm internal API change

See xtermjs/xterm.js#4207
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
* Revert "Revert "Update xterm.js" (microsoft#164002)"

This reverts commit 462ecfa.

* Adopt xterm internal API change

See xtermjs/xterm.js#4207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve names of IRenderDimensions interface members

1 participant