Fix a bunch of memory retention problems#4185
Merged
Tyriar merged 11 commits intoxtermjs:masterfrom Oct 8, 2022
Merged
Conversation
A common mistake made was overriding dispose and not calling super.dispose, so a TS trick is now used to move it to a readonly property instead of a member method which prevents it being overridden.
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Improve dotted line for canvas xtermjs/xterm.js#4100 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can no longer override
Disposable.disposeas this introduced a common problem where a subsection of objects intended to be disposed weren't being disposed. This also registers all event emitters and makes some services disposable that should have been.Fixes #4167