Skip to content

Fix clearTextureAtlas call as implemented on IRenderer#4180

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:clear_atlas
Oct 7, 2022
Merged

Fix clearTextureAtlas call as implemented on IRenderer#4180
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:clear_atlas

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Oct 7, 2022

This is the root cause of microsoft/vscode#162996

@Tyriar Tyriar enabled auto-merge October 7, 2022 21:24
@Tyriar Tyriar merged commit 5fcb084 into xtermjs:master Oct 7, 2022
@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Oct 7, 2022

This is a bug where Terminal.clearTextureAtlas wasn't doing anything for webgl, but I think the main bug still remains

Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Improve dotted line for canvas xtermjs/xterm.js#4100
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Tyriar added a commit to microsoft/vscode that referenced this pull request Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195
- Fix demo again xtermjs/xterm.js#4193
- Switch to Ubuntu 20.04 xtermjs/xterm.js#4192
- Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180
- Create theme service xtermjs/xterm.js#4188
- Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189
- Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187
- Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants