Allow renderer to be set before Terminal.open is called#4151
Merged
Tyriar merged 4 commits intoxtermjs:masterfrom Oct 7, 2022
Merged
Allow renderer to be set before Terminal.open is called#4151Tyriar merged 4 commits intoxtermjs:masterfrom
Tyriar merged 4 commits intoxtermjs:masterfrom
Conversation
dstein64
added a commit
to dstein64/gifcast
that referenced
this pull request
Dec 20, 2022
Also, loadAddon can be called earlier as of xterm.js #4151. xtermjs/xterm.js#4151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4133
Just realized I didn't push this yesterday, will need to verify again as I might have gotten distracted and not finished it.