Use <details> tag for real-world uses#4146
Use <details> tag for real-world uses#4146dstein64 wants to merge 1 commit intoxtermjs:masterfrom dstein64:master
Conversation
Tyriar
left a comment
There was a problem hiding this comment.
I think this would defeat a lot of the purpose of it being there as almost no one would expand and therefore we would get less PRs/engagement coming out way.
How about instead we just move it to the bottom, below releases/contributing and above license?
Sure. I can make that update to this PR. Would you be interested in any of the following as either part of or instead of the update to move the section:
|
It was always "first come, first serve", so the earliest adopters are more prominently presented in the list. When alphabetizing, we would still want a select few at the top of the list, so the more important entries don't get buried and it gets a little complicated selecting those. Easiest it just to keep it as is
I don't think there's much point adding interactivity like this at the bottom of a readme as it would rarely get clicked. |
I made the update in a separate PR, moving the real-world uses section below releases/contributing and above license. |
This update puts the real-world use examples in a
<details>tag so that it must be manually expanded.The idea is to simplify the
README.mdpage, for which the example real-world uses currently takes a large portion.Is this a change you'd be interested in merging? If so, please let me know if there are any updates I should make.
The updated version can be viewed at:
https://github.com/dstein64/xterm.js/blob/master/README.md#real-world-uses