Skip to content

SGR-pixels mouse report#4093

Merged
jerch merged 4 commits intoxtermjs:masterfrom
jerch:sgr_pixels
Sep 1, 2022
Merged

SGR-pixels mouse report#4093
jerch merged 4 commits intoxtermjs:masterfrom
jerch:sgr_pixels

Conversation

@jerch
Copy link
Copy Markdown
Member

@jerch jerch commented Aug 31, 2022

Closes #4092.

TODO:

  • fix cell to pixel offsets translation
  • fix bounding box offsets (seems chrome reports mouse events slightly off the real box?) silly one: system actually draws pointer arrow slightly off
  • API mouse tests
  • vt feature docs

@jerch
Copy link
Copy Markdown
Member Author

jerch commented Sep 1, 2022

@Tyriar Cant get mouse.wheel working with playwright, although it is supported since 1.15. Thus I disabled all wheel related tests and re-enabled all other mouse tests.

@jerch jerch marked this pull request as ready for review September 1, 2022 12:03
@jerch jerch merged commit f9db65c into xtermjs:master Sep 1, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SGR-pixels mouse reports support

2 participants