Merged
Conversation
Member
Author
|
This is basically done, I'm going to wait until next month to push it though considering the amount of changes that are already in this month. |
|
@Tyriar I know lots of people looking forward to get hyperlink support enabled in xterm. Lost of vscode users will be thrilled to see this in sooner. |
Member
Author
|
@ssbarnea should land in 1.72 🙂 |
glensc
reviewed
Aug 30, 2022
Member
|
@Tyriar Oh well abit late to the party - do you think this should get a review? Sorry the PR kinda went unnoticed to me... |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous attempts: #2904, #3904
Fixes #1134
This sets up the model side of multiple range support but does not implement it, there's an example in the demo test button that should work when it's done: