Fix mocha test explorer #3966
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Jul 30, 2022
silamon:mochaunittestback
Merged
Fix mocha test explorer #3966Tyriar merged 3 commits intoxtermjs:masterfrom silamon:mochaunittestback
Tyriar merged 3 commits intoxtermjs:masterfrom
silamon:mochaunittestback
Conversation
Tyriar
requested changes
Jul 30, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Sorry about the revert, test-api still works with this though👍
Contributor
Author
|
Don't merge this branch yet. The mocha test explorer didn't got all the functionality back it had with the config file. |
Member
|
@silamon np, mark ready for review when it's ready to make sure I don't merge early |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by #3934. Sort of alternative solution to keep the mocha test explorer working for unit tests.
Somebody needs to check if I didn't break the api tests again.
When mocha doesn't have a config flag passed, it takes by default the nearest file it can find.