Skip to content

Underline style and color rendering#3921

Merged
Tyriar merged 26 commits intoxtermjs:masterfrom
Tyriar:underline
Jul 30, 2022
Merged

Underline style and color rendering#3921
Tyriar merged 26 commits intoxtermjs:masterfrom
Tyriar:underline

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented Jul 23, 2022 •
edited
Loading

Fixes #1145

This sets up the infrastructure for 3-keyed glyphs where the new key is ext. Currently ext is set to underlineStyle but will be moved to use the packed ext format, similar to fg/bg.

DOM

Screen Shot 2022-07-23 at 9 22 19 am

Canvas

Screen Shot 2022-07-23 at 9 22 41 am

Webgl

Screen Shot 2022-07-23 at 9 22 55 am

@Tyriar Tyriar added this to the 4.20.0 milestone Jul 23, 2022
@Tyriar Tyriar self-assigned this Jul 23, 2022
@Tyriar Tyriar changed the title Underline style rendering Underline style and color rendering Jul 23, 2022
@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 23, 2022

Colors done too:

DOM

Screen Shot 2022-07-23 at 11 20 44 am

Canvas

Screen Shot 2022-07-23 at 11 20 25 am

Webgl

Screen Shot 2022-07-23 at 11 19 12 am

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 23, 2022

No more overlapping of text/underline:
Screen Shot 2022-07-23 at 2 28 53 pm

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 23, 2022

Continuous curves 😍

Screen Shot 2022-07-23 at 2 49 04 pm

@Tyriar Tyriar mentioned this pull request Jul 25, 2022
Closed
7 tasks
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 30, 2022

dpr 1 curly rendering on Windows isn't great atm:

image
image

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 30, 2022

Updated, it was bad when line width was 1:

image

image

@Tyriar
Copy link
Copy Markdown
Member Author

Tyriar commented Jul 30, 2022

Glyph threshold clearing is causing an issue for underlines:

image

@Tyriar
Disable threshold check for glyphs with colored underlines
f0ddaf4 
This causes some underlines to disappear which looks very bad for
colored underlines
@Tyriar Tyriar merged commit 640596b into xtermjs:master Jul 30, 2022
@Tyriar Tyriar deleted the underline branch July 30, 2022 14:46
@Tyriar Tyriar mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Curly and colored underlines

1 participant

@Tyriar