Only send wheel mouse event when scrolling a line or more#3869
Merged
Tyriar merged 2 commits intoxtermjs:masterfrom Jun 26, 2022
Merged
Only send wheel mouse event when scrolling a line or more#3869Tyriar merged 2 commits intoxtermjs:masterfrom
Tyriar merged 2 commits intoxtermjs:masterfrom
Conversation
Contributor
Author
|
Re-using viewport's xterm.js/src/browser/Terminal.ts Line 863 in 52044e9 |
Tyriar
approved these changes
Jun 26, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks good, I agree it's not ideal we're using this from Viewport but as you say it's used elsewhere already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3848.
Haven't added a test since all of the mouse event functionality seems to be untested and I'm not sure how to set up the necessary scaffolding.