Skip to content

Highlight all matches in demo by default#3786

Merged
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:default_highlight
May 12, 2022
Merged

Highlight all matches in demo by default#3786
Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar:default_highlight

Conversation

@Tyriar
Copy link
Copy Markdown
Member

@Tyriar Tyriar commented May 12, 2022

No description provided.

@Tyriar Tyriar added this to the 4.19.0 milestone May 12, 2022
@Tyriar Tyriar requested a review from meganrogge May 12, 2022 17:54
@Tyriar Tyriar self-assigned this May 12, 2022
Copy link
Copy Markdown
Member

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if the overview ruler decorations showed up immediately.. they currently don't because we require that option to be explicitly set

https://github.com/tyriar/xterm.js/blob/edba006045ea2a9acf459385bae442ed0d5ad5d7/src/browser/Terminal.ts#L610-L616

overview.mov

@Tyriar Tyriar merged commit 7d4b614 into xtermjs:master May 12, 2022
@Tyriar Tyriar deleted the default_highlight branch May 12, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants