Don't change overview ruler position based on decorations#3711
Merged
Tyriar merged 1 commit intoxtermjs:masterfrom Mar 24, 2022
Merged
Don't change overview ruler position based on decorations#3711Tyriar merged 1 commit intoxtermjs:masterfrom
Tyriar merged 1 commit intoxtermjs:masterfrom
Conversation
The original fix for xtermjs#3705 ended up revealing this other bug; the canvas shouldn't be set based on the anchor of its decorations. Fixes xtermjs#3705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original fix for #3705 ended up revealing this other bug; the canvas
shouldn't be set based on the anchor of its decorations.
Fixes #3705
Updating was causing this bug: