Skip to content

add ST sequence, fix emacs#3704

Merged
meganrogge merged 10 commits intoxtermjs:masterfrom
meganrogge:emacs
Mar 23, 2022
Merged

add ST sequence, fix emacs#3704
meganrogge merged 10 commits intoxtermjs:masterfrom
meganrogge:emacs

Conversation

@meganrogge
Copy link
Copy Markdown
Member

@meganrogge meganrogge commented Mar 23, 2022

fixes #3700

emacs.mov

@meganrogge meganrogge self-assigned this Mar 23, 2022
@meganrogge meganrogge requested a review from Tyriar March 23, 2022 15:49
@jerch
Copy link
Copy Markdown
Member

jerch commented Mar 23, 2022

@meganrogge Your ST got somewhat scrambled, and it is already defined C1 (further down). But I suggest not to use the naked 8-bit value, as some encodings will screw things up with 8bit. It should be safe to use the ESC notation instead (which is ESC \ for ST).

@meganrogge meganrogge requested a review from jerch March 23, 2022 16:56
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 23, 2022
Copy link
Copy Markdown
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (tests still need to be adjusted)

meganrogge and others added 2 commits March 23, 2022 15:43
This reverts commit becab08.
Co-authored-by: jerch <[email protected]>
@meganrogge meganrogge enabled auto-merge March 23, 2022 21:40
@meganrogge meganrogge merged commit d57329f into xtermjs:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emacs xterm specific initialization does not complete properly

3 participants