Show all matches when searching#3698
Merged
Tyriar merged 63 commits intoxtermjs:masterfrom Mar 22, 2022
Merged
Conversation
Tyriar
requested changes
Mar 21, 2022
Comment on lines
+69
to
+76
| this._onDataDisposable = this._terminal.onData(() => { | ||
| this._dataChanged = true; | ||
| setTimeout(() => { | ||
| if (this._lastSearchOptions?.decorations && this._cachedSearchTerm && this._resultDecorations.size > 0 && this._lastSearchOptions) { | ||
| this._highlightAllMatches(this._cachedSearchTerm, this._lastSearchOptions,'previous'); | ||
| } | ||
| }, 200); | ||
| }); |
Member
There was a problem hiding this comment.
This should get debounced to ensure we're not doing this every 200 ms, but only 200ms after no event
Comment on lines
+71
to
+75
| setTimeout(() => { | ||
| if (this._lastSearchOptions?.decorations && this._cachedSearchTerm && this._resultDecorations.size > 0 && this._lastSearchOptions) { | ||
| this._highlightAllMatches(this._cachedSearchTerm, this._lastSearchOptions,'previous'); | ||
| } | ||
| }, 200); |
Member
There was a problem hiding this comment.
This create a new timeout on every onData event, there should only be a single timeout active at any time.
Tyriar
reviewed
Mar 21, 2022
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
requested changes
Mar 21, 2022
An embedder may not want to enable it
Tyriar
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653
Part of microsoft/vscode#134790