Fix triple select edge case#3669
Merged
Tyriar merged 2 commits intoxtermjs:masterfrom Mar 31, 2022
silamon:tripleselect
Merged
Conversation
Tyriar
requested changes
Mar 2, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looked into this and it still doesn't look quite right:
Notice:
- The flash when you drag up
- The wrapped selection is only retained when you drag up
- Dragging down doesn't keep the line selected
Ideally once triple click happens that initially selected wrapped line will always be selected. We're basically after exactly what monaco does:
Contributor
Author
That's exactly the note which was mentioned in the PR description. It's now also fixed on this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the length of the (wrapped) line in selectionStartLength instead of selectionEnd. Upon dragging, the selection end is modified, but the wrapped line remains selected thanks to the selectionStartLength. ( Same behavior as selecting a word. )
Tests have been adjusted to include this.
Note: Dragging still select lines, instead of wrapped lines.EDIT: Fixed as well.Fixes #3670
Related microsoft/vscode/#135567
See also #1456 (comment)