Skip to content

Replace all getOption/setOption usage with options#3667

Merged
Tyriar merged 3 commits intoxtermjs:masterfrom
childrentime:dev_wlw
Mar 31, 2022
Merged

Replace all getOption/setOption usage with options#3667
Tyriar merged 3 commits intoxtermjs:masterfrom
childrentime:dev_wlw

Conversation

@childrentime
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

Copy link
Copy Markdown
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Tyriar Tyriar added this to the 4.19.0 milestone Mar 2, 2022
@Tyriar Tyriar enabled auto-merge March 31, 2022 16:00
@Tyriar Tyriar merged commit 47fe7b2 into xtermjs:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants