trycatch font parsing in ligatures addon#3618
trycatch font parsing in ligatures addon#3618LabhanshAgrawal wants to merge 1 commit intoxtermjs:masterfrom
Conversation
|
Tests failing on and As these expect errors being thrown which this pr suppresses, any suggestions? |
LabhanshAgrawal
force-pushed
the
trycatch
branch
from
31a7a7c to
325fad4
Compare
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
to ligatures addon directly so that it can be used with older xterm.js versions
@LabhanshAgrawal isn't the right fix here to use the correct ligatures addon for the xterm.js version and update xterm.js if it's not fixed before? Throwing here and using the existing catch does seem like the more correct thing to do (instead of having a catch in xterm that would never be hit).
|
Closing out since #3617 can now be fixed by updating to latest webgl beta |
The issue was due to opentype not being able to parse some font on macOS 12, so none of the earlier ligatures addon versions would be able to work in that scenario even with previous xterm versions.
Didn't really get what you're referring to here.
👍 |
Would just prefer not to have try/catches everywhere when only one of them should be used in practice. We prefer to take a more evergreen approach as supporting older versions takes a bunch of effort. |
2 participants
Adding the fix for #3547 to ligatures addon directly so that it can be used with older xterm.js versions
Ref #3617